Per my comment in https://github.com/clojure-emacs/clj-refactor.el/pull/521#issuecomment-1179577092, this PR makes no changes in the current behavior, but extracts and breaks up the current logic to facilitate using a defcustom in a later PR to select the magic require logic. In addition, it adds test coverage for each the methods extracted. My intention is to rebuild the changes in #521, as a sequence of commits on top of this. My hope is if this is merged, we can introduce a defcustom feature flag inside of cljr-slash, that will re-use some of these helpers but will otherwise be an independent change.
For review, I would recommend going through the first 3 commits step by step as they are clean changes, everything after I can squash as a single commit if preferred as they are just adding test coverage to the extracted methods.
Thanks in advance for your review!
Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
Per my comment in https://github.com/clojure-emacs/clj-refactor.el/pull/521#issuecomment-1179577092, this PR makes no changes in the current behavior, but extracts and breaks up the current logic to facilitate using a defcustom in a later PR to select the magic require logic. In addition, it adds test coverage for each the methods extracted. My intention is to rebuild the changes in #521, as a sequence of commits on top of this. My hope is if this is merged, we can introduce a defcustom feature flag inside of cljr-slash, that will re-use some of these helpers but will otherwise be an independent change.
For review, I would recommend going through the first 3 commits step by step as they are clean changes, everything after I can squash as a single commit if preferred as they are just adding test coverage to the extracted methods.
Thanks in advance for your review!
Before submitting a PR make sure the following things have been done (and denote this by checking the relevant checkboxes):
cask exec emacs -batch -Q -L . -eval "(progn (setq byte-compile-error-on-warn t) (batch-byte-compile))" clj-refactor.el
)./run-tests.sh
)Thanks!