Deprecate unused reader-conditional functions and transition to new

dgtized commented 1 year ago

Cleanup PR to close out https://github.com/clojure-emacs/clj-refactor.el/issues/533. I initially marked each function as obsolete but then remembered these are conventionally private API so probably not worth the obsolete tag. We can re-apply obsolete if needed though by reverting the last commit. I also left TODOs on the remaining deprecated reader-conditional functions like cljr--clj-context-p to clarify they are being removed and when. Once we switch to enable cljr-slash-uses-suggest-libspec, there are quite a number of functions that can be removed, but I wanted to mark the ones specifically related to context in this PR.

One other thing, tests are passing on CI on my fork, but it appears tests are failing on the official repo because the circle CI ssh key for github is invalidated, and hasn't been refreshed? I suspect that requires a circle ci account owner for the main repo to resolve.

Before submitting a PR make sure the following things have been done (and denote this by checking the relevant checkboxes):

[x] The commits are consistent with our contribution guidelines
[x] You've added tests (if possible) to cover your change(s) -- no need for tests on removed functions
[x] The new code is not generating byte compile warnings (run cask exec emacs -batch -Q -L . -eval "(progn (setq byte-compile-error-on-warn t) (batch-byte-compile))" clj-refactor.el)
[x] All tests are passing (run ./run-tests.sh)
[x] You've updated the changelog (if adding/changing user-visible functionality)
[x] You've updated the readme (if adding/changing user-visible functionality) -- I can add a changelog/readme if needed but it's not changing user-visible functionality.

vemv commented 1 year ago

Looking good, sorry for the delay.

Probably I'll merge this after a last look later in the week.

dgtized commented 1 year ago

Checking back in, did you get a chance to review? No worries if too busy, just making sure this doesn't fall off your radar.

vemv commented 1 year ago

Yes it's pinned (top 5) in gmail. Sorry for the nuisance.

Actually I have some capacity incoming (except for the mild sickness I got this week)

Looking forward to give clj-refactor / r-nrepl a spin!

vemv commented 1 year ago

Thanks! I re-enabled builds as well (https://batsov.com/articles/2022/09/20/resetting-circleci-checkout-ssh-keys/ )

clojure-emacs / clj-refactor.el

Deprecate unused reader-conditional functions and transition to new #542