Identify `basilisp.edn` and `.lpy` file extensions as Clojure type

ikappaki commented 7 months ago

Before submitting a PR mark the checkboxes for the items you've done (if you think a checkbox does not apply, then leave it unchecked):

[x] The commits are consistent with our [contribution guidelines][1].
[ ] You've added tests (if possible) to cover your change(s). Bugfix, indentation, and font-lock tests are extremely important!
[ ] You've run M-x checkdoc and fixed any warnings in the code you've written.
[x] You've updated the changelog (if adding/changing user-visible functionality).
[ ] You've updated the readme (if adding/changing user-visible functionality).

I haven't added any tests yet because of the simplicity of the change and closely following the .clj paradigm, but let me know if this is of concern.

The basilisp.edn file is a project placeholder that has no other use at the moment other to provisionally indicate this is the root of a Basilisp project.

I plan to add some syntax highlighting for builtin Basilisp symbol at some later point, at the moment I'm just looking at minimal support to get it working with Cider.

Thanks

bbatsov commented 7 months ago

Thanks!

ikappaki commented 7 months ago

(CI breaks are unrelated and most likely due to https://github.com/jorgenschaefer/emacs-buttercup/issues/244)

ikappaki commented 4 months ago

Hi @bbatsov / @vemv,

could you please release this to melpa stable?

I plan to provide jack in support in cider and need to reference it as a dependency.

thanks

vemv commented 4 months ago

Hi @ikappaki ,

a stable release should be out soon enough. It's been in the works.

Probably first day of June would be a reasonable deadline for us to wrap any stuff in flight.

Cheers - V

bbatsov commented 4 months ago

Probably first day of June would be a reasonable deadline for us to wrap any stuff in flight.

@vemv Do we have anything anything in progress for clojure-mode? Looking at the changelog and the issues I don't see anything we need to tackle.

vemv commented 4 months ago

ah sorry, thought this was cider.

ikappaki commented 4 months ago

thanks guys, when do you anticipate being able to make the next release?

vemv commented 4 months ago

Let me do it just now

vemv commented 4 months ago

Tagged! It will be visible on MELPA in a couple hours.

ikappaki commented 4 months ago

Thanks @vemv,

one last thing, is the releases page still relevant? It hasn't been updated since version 5.16.

https://github.com/clojure-emacs/clojure-mode/releases

vemv commented 4 months ago

That could be just me as I don't have the habit of creating releases (except in CIDER).

tbh it's quite a bit of busy work, especially as we already have tags and changelog. Sadly it's not automatable OOTB.

https://github.com/clojure-emacs/cider-nrepl/releases also has lagged behind. Thoughts? @bbatsov

bbatsov commented 4 months ago

I always create the releases manually when I do them. It's a bit of manual work indeed, but it takes only a minute and it's useful for the users, as those appear automatically on the project homepage. I'd recommend to backfill the missing releases, as that will take only a couple of minutes.

bbatsov commented 4 months ago

I just added the missing entries for clojure-mode.

clojure-emacs / clojure-mode

Identify `basilisp.edn` and `.lpy` file extensions as Clojure type #676