clojure-emacs / clojure-ts-mode

The next generation Clojure major mode for Emacs, powered by TreeSitter
GNU General Public License v3.0
129 stars 11 forks source link

Some paths in "Compile From Source" are off a bit #29

Open sogaiu opened 8 months ago

sogaiu commented 8 months ago

As pointed out in https://github.com/clojure-emacs/clojure-ts-mode/pull/27, some paths for the "Compile From Source" instructions are off for both Linux and macOS.

For example, for Linux I currently see:

mkdir -p dist
cc -c -I./src src/parser.c -o "parser.o"
cc -fPIC -shared src/parser.o -o "dist/libtree-sitter-clojure.so"

The second cc invocation refers to a .o that's not likely to exist from just following the instructions. Likely to lead to a better result might be:

mkdir -p dist
cc -c -I./src src/parser.c -o "src/parser.o"
cc -fPIC -shared src/parser.o -o "dist/libtree-sitter-clojure.so"

That is, have the first cc invocation put the .o file in the src subdirectory.

A similar situation holds for the current macOS instructions.

One way to amend those might be:

mkdir -p dist
cc -c -I./src src/parser.c -o "src/parser.o"
cc -fPIC -shared src/parser.o -o "dist/libtree-sitter-clojure.dylib"
dannyfreeman commented 7 months ago

Now that Emacs compiles from source for you I may remove these instructions and instead link to somewhere else that has them instead.