Support toplevel defs with metadata

clojure-emacs / clojure-ts-mode

The next generation Clojure major mode for Emacs, powered by TreeSitter

GNU General Public License v3.0

129 stars 11 forks source link

Support toplevel defs with metadata #43

Open kommen opened 5 months ago

kommen commented 5 months ago

Towards fixing #42

Pushing this as WIP and to collect feedback from others if this is the right approach.

[x] don't indent a toplevel def with metadata
[x] font lock toplevel def with metadata
[ ] font lock toplevel def symbol name
[ ] make toplevel def with metadata findable via imenu
[ ] don't indent a toplevel vector, set or map with metadata

bbatsov commented 3 months ago

I guess that's still waiting for feedback, right?

kommen commented 3 months ago

@bbatsov yes, feedback very welcome! however, I'm using this PR in my prod emacs setup for a few months now and it seems to work as intended. So I would be somewhat confident to merge it for now as is and continue with the remaining todos in a follow up, if no one else has objections.