search

clojure-emacs / clojure-ts-mode

The next generation Clojure major mode for Emacs, powered by TreeSitter
GNU General Public License v3.0
129 stars 11 forks source link

Do not provide the test-helper feature #44

Closed tarsius closed 2 months ago

tarsius commented 2 months ago

test-helper.el isn't a library intended to be loaded with require. Instead it is loaded with load by ert-runner itself and that does not use require to do so.

Because of that, it is confusing to provide a feature. It also wouldn't be possible to use require to reliably load test-helper because that might, depending on the order of load-path, load the test-helper.el of another package.

There aren't many packages left that have that defect but that's only because I got them to fix this issue. It would be great if you could fix it in your package as well.

This is also discussed at rejeep/ert-runner.el#38.

dannyfreeman commented 2 months ago

Thank you for reporting this. It was an easy change so I got it cleaned up.

tarsius commented 2 months ago

You're welcome and thanks for the quick action.