search

clojure-emacs / logjam

An interactive, nrepl-oriented logging backend
Eclipse Public License 1.0
1 stars 0 forks source link

Excluding loggers #13

Closed vemv closed 6 months ago

vemv commented 6 months ago

I'd like to exclude certain loggers, e.g. org.eclipse.jetty.server.Server, org.eclipse.jetty.server.AbstractConnector

I don't think this is nicely expressable with the current filters.

So I was thinking of introducing a logger-pattern or loggers-blocklist. Maybe both.

Thoughts? @r0man

r0man commented 6 months ago

Sounds good to me. Maybe choose a more obvious name? rename loggers to included-loggers, and use excluded-loggers?

vemv commented 6 months ago

I guess we can perform that breaking change and smooth it out Elisp-side.

However I'd prefer loggers-allowlist (or loggers-whitelist) to clearly reflect that that only allowlisted would make it in.

(as I see it, included-loggers doesn't capture so well the "exclusive inclusion" concept).

Self-assigned.

r0man commented 6 months ago

Ok, let's go with allow/block (or anything similar) rather than black/white.