Run test suite for :cljs branches

clojure-emacs / orchard

A fertile ground for Clojure tooling

Eclipse Public License 1.0

326 stars 54 forks source link

Run test suite for :cljs branches #150

Open vemv opened 2 years ago

vemv commented 2 years ago

There are a few :cljs branches in our reader conditionals, but there isn't a cljs runner in our CI.

This means an important hole in test coverage.

(Thanks for spotting this @lread)

lread commented 2 years ago

The context is me looking into an issue @vemv raised on cljdoc. He had an awesome idea that I was exploring, and initial experiments look promising for cljdoc Clojure analysis. But when the cljdoc analyzer saw cljc files in orchard, it tried ClojureScript analysis and that failed. I was wondering if this failure was cljdoc's or orchard's.

So I dug into orchard (a very wee bit) to see if there were cljs tests. I do see test-cljs/orchard/cljs but don't understand if/how these are run.

lread commented 2 years ago

FWIW, cljdoc now allows you to select which languages are analyzed. To only have cljdoc analyze for clj (and not cljs), a ./doc/cljdoc.edn with the following contents should do the trick:

{:cljdoc/languages ["clj"]}

Lemme know if you want a PR.

vemv commented 2 years ago

Nice feature!

PR would be perfect, thanks! Same for cider-nrepl, refactor-nrepl

lread commented 2 years ago

PR would be perfect, thanks! Same for cider-nrepl, refactor-nrepl

@vemv, PR done for this repo, for your next release to clojars, cljdoc should build fine, feel free to ping me if there are any issues.

I had a quick look at the following for you:

cider-nrepl - seems like cljdoc is failing to analyze for clj so not the same issue.
refactor-nrepl - also a clj analysis failure Lemme know if you want help getting these working on cljdoc and we'll see what we can do, but probably better to visit cljdoc slack channel and/or raise cljdoc GitHub issues.

vemv commented 2 years ago

Cheers! 🍻

Both projects depend on Orchard, so starting there seems on the safe side.