search

clojure-emacs / orchard

A fertile ground for Clojure tooling
Eclipse Public License 1.0
326 stars 54 forks source link

Remove javadoc fallback #160

Closed vemv closed 6 months ago

vemv commented 2 years ago

https://github.com/clojure-emacs/orchard/blob/c0e24f71292f4fed8d4d8cf854a99e4a80cf6ee6/src/orchard/java.clj#L385

11 isn't a special JDK and defaulting to it can mask issues (especially as we complete and enable enrich-classpath)

bbatsov commented 2 years ago

Isn't this unrelated to to what enrich-classpath does? It simply computes the URL for the remote JavaDoc. I think 11 was the newest LTS when this was written, that's why it was the default.

vemv commented 2 years ago

But 11 (or any single choice) isn't accurate, also can lack results for the newer classes that can get added for each JDK.

When enrich-classpath gets its finishing touch I'd feel more comfortable tweaking this section of code.

bbatsov commented 2 years ago

Yeah, that's fair. Frankly, I'm not sure in which case java-api-version might return nil to begin with. I guess this fallback simply guards against this case.

alexander-yakushev commented 7 months ago

This was addressed in https://github.com/clojure-emacs/orchard/commit/bb22fb37938087ebf40880cd1322e0ad93b79126, right?

vemv commented 6 months ago

SGTM. We don't give a lot of uses to javadoc anyway

https://github.com/clojure-emacs/cider/issues/3575