Fix inspector navigation fns to work with pagination

clojure-emacs / orchard

A fertile ground for Clojure tooling

Eclipse Public License 1.0

326 stars 54 forks source link

Closed p4v4n closed 8 months ago

p4v4n commented 9 months ago

Makes next-sibling, previous-sibling, and down fns work well with pagination.
next-sibling will continue to not go beyond the current page.
Adds out-of-bound checks for down, next-sibling, next-page, and previous-page fns.
Handle discrepancy with page-size and items-on-page when inspecting hash-maps.

bbatsov commented 9 months ago

@alexander-yakushev feel free to take a look as well.

vemv commented 8 months ago

Great work! It's been a pleasure to see coverage grow commit after commit.

I'll try this out locally. Feel free to, as well.

Cheers - V

vemv commented 8 months ago

Merging and releasing this in cider-nrepl today

tbh I didn't have the chance to try it out, but based on code review and the test coverage, it certainly looks like a great overall improvement.

I have a little personal app where I use next-sibling all the time so any possible improvement won't escape our radar.

Cheers - V