Next/previous sibling functions - refinements

[vemv]

Hi @p4v4n , I checked out the recent changes. While it's an improvement over how things were before, there's still some room for refinements.

Let's assume an Inspector object with two pages.

• In page 1, next-sibling on the last item should get me to the first element of the page 2
  • (curently: does nothing)
• On page 2, previous-sibling on the first item should get me to the last element of the page 1
  • (currently: fails by returning nil instead of the current inspector)

Overall, I find that the correct behavior is that by using next/previous sibling, the user should be able to go smoothly from the first element of the first page to the last element of the last page, no matter how many pages are there in between.

It should also work in the opposite direction (last item of last page to first item of first page).

Normally, if we try to get past boundaries, we should re-render the same inspector instead of returning nil.

The current state of things can be tried in cider master / cider-nrepl latest.

Cheers - V

[p4v4n]

Hey, I missed this notification and also didn't find the time to try the latest changes yet. Thanks for testing the PR and taking it over the finish line.

Some initial thoughts:

• I agree with the ideal behavior.
• next-sibling behavior is currently expected. Didn't try to support it across pages as mentioned in the PR mainly to limit the scope.

• previous-sibling behavior is surprising. Excepted it to work already across all the pages based on the current code.

  Will look into both issues within the next couple of weeks and get back.

[vemv]

Thanks @p4v4n ! It's no issue and the current state is an acceptable intermediate one.

Would look forward to a PR anytime

[p4v4n]

Just a small update. I tried the latest cider and cider-nrepl and tried the latest code and previous-sibling works fine for me across all pages.

Steps I tried to reproduce:

1. Inspect (range 100) 2. Go to page 4 3. Go down into any element 4. Press '9' 100 times.

It goes back to 0 and stops as expected.

[vemv]

Tried out quickly - you're right!