search

clojure-emacs / orchard

A fertile ground for Clojure tooling
Eclipse Public License 1.0
326 stars 54 forks source link

Allow `inspector/next-sibling` to go beyond the current page #233

Closed p4v4n closed 6 months ago

p4v4n commented 6 months ago

Closes https://github.com/clojure-emacs/orchard/issues/232

I haven't faced any issues using previous-sibling across pages. Described the steps to reproduce in the issue.

This change allows next-sibling also to jump across pages.

vemv commented 6 months ago

Thanks for the quick iteration!

If you have the chance please make install Orchard and cider-nrepl (per their readmes) and test-drive this. Last time there was a minor bug in the cider-nrepl integration.

If it's too much hassle, I'll do it before Monday

(but I always appreciate the extra eyes for QA)

Cheers - V

p4v4n commented 6 months ago

If you have the chance please make install Orchard and cider-nrepl (per their readmes) and test-drive this. Last time there was a minor bug in the cider-nrepl integration.

I need to check how to do this.

Maybe lein install to replace orchard and running tests in cider-nrepl is also enough.

Anyways happy to wait and I will also try to figure it over the weekend.

vemv commented 6 months ago

Thanks!

vemv commented 6 months ago

I merged to keep things agile.

Still I'll leave some headroom for both of us to QA - I'll release the stuff next week :)

vemv commented 6 months ago

https://clojars.org/cider/cider-nrepl/versions/0.47.1 is now available