Updated version.clj - Githubissues

dotemacs commented 11 months ago

[x] The commits are consistent with our contribution guidelines ~- [ ] You've added tests (if possible) to cover your change(s)~
[x] All tests are passing (run lein do clean, test)
[] Code inlining with mranderson works and tests pass with inlined code (run ./build.sh install -- takes a long time) ~- [ ] You've updated the changelog (if adding/changing user-visible functionality)~ ~- [ ] You've updated the readme (if adding/changing user-visible functionality)~

version-clj makes me nervous as it went 1.x -> 2.x with no changelog.

I guess not everybody uses CHANGELOGs...

The project, version-clj, was on version 1.0.0 before update to 2.0.0.

It only uses one function from version-clj in refactor-nrepl.artifacts/artifact-versions: version-sort:

This is the change that went into that function from version 1.0.0 to 2.0.0:

No change to the actual function, but that function uses version-compare function, which did have a change, see:

If you look at this commit: https://github.com/xsc/version-clj/commit/c05eeb8dffedda072fa41c9210cfc43cd6f1d0fd you'll see that the tests for version-sort & version-compare were added for the release 1.0.0 and were not amended at the latest release 2.0.2.

And finally a pedantic comparison of version 1.0.0 & the current stable release 2.0.2 (which is this commit's update):

dotemacs commented 11 months ago

Running lein do clean, test locally, the tests pass.

As well as 7/13 CI jobs.

Can you please re-run the tests on all the CI profiles, to ensure that it's not just a glitch?

Thanks

vemv commented 11 months ago

Cheers 🍻

clojure-emacs / refactor-nrepl