Closed DerGuteMoritz closed 8 months ago
As discussed via Slack earlier today.
Aside: Looks like the "Code inlining with mranderson" mentioned in the checklist is outdated - there's no build.sh (anymore). Instead, I successfully ran make install which seems to be equivalent. Maybe this needs to be updated?
build.sh
make install
lein do clean, test
./build.sh install
Thanks! Perfect PR, kudos.
Yes, please add a commit removing that checkbox.
Cheers. I'll cut a release soon, but I take it that the make install cuts it for now
As discussed via Slack earlier today.
Aside: Looks like the "Code inlining with mranderson" mentioned in the checklist is outdated - there's no
build.sh
(anymore). Instead, I successfully ranmake install
which seems to be equivalent. Maybe this needs to be updated?lein do clean, test
)./build.sh install
-- takes a long time)