search

clojure-emacs / squiggly-clojure

Flycheck checker for Clojure, using eastwood and core.typed.
GNU General Public License v3.0
204 stars 25 forks source link

Use `cider-tooling-eval` #38

Closed tanzoniteblack closed 8 years ago

tanzoniteblack commented 8 years ago

Instead of using cider-nrepl-request:eval, which invokes the spinner in the REPL, use cider-tooling-eval.

The real reason behind this change has nothing to do with the spinner itself, but when the spinner is spinning, the cider refuses to evaluate any new code. Which means, that while a buffer is flychecking, I can't use the repl or re-compile code, using cider-tooling-eval let's the checkers run in the background, only interacting with the user's workflow when emacs is actually processing the results.

pnf commented 8 years ago

This looks reasonable, but it appears to be a partial reversion of f6d5006

-  (nrepl-request:eval input callback nil (cider-current-tooling-session)))
+ (cider-nrepl-request:eval input callback))

which removed the session specification now made in the cider-tooling-eval wrapper. Since I don't understand this well, could @expez comment?