search

clojure-emacs / squiggly-clojure

Flycheck checker for Clojure, using eastwood and core.typed.
GNU General Public License v3.0
204 stars 25 forks source link

Convert (:squiggly env) to datastructure in case it's a string #50

Closed OlegTheCat closed 7 years ago

OlegTheCat commented 7 years ago

This should close #49. Also, I'm wondering is it worth to bump environ to 1.1.0 here. What do you think?

pnf commented 7 years ago

I think so. I generally try to keep the dependencies up to date but apparently missed this one.

On Mar 25, 2017, at 12:24 PM, Oleh Palianytsia notifications@github.com wrote:

This should close #49. Also, I'm wondering is it worth to bump environ to 1.1.0 here. What do you think?

You can view, comment on, or merge this pull request online at:

https://github.com/clojure-emacs/squiggly-clojure/pull/50

Commit Summary

Convert (:squiggly env) to datastructure in case it's a string File Changes

M src/squiggly_clojure/core.clj (10) Patch Links:

https://github.com/clojure-emacs/squiggly-clojure/pull/50.patch https://github.com/clojure-emacs/squiggly-clojure/pull/50.diff ― You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

OlegTheCat commented 7 years ago

@pnf, done.

pnf commented 7 years ago

Merged. Thanks. This will also allow people to use OS environment variables if for some reason they want to.