"C-c ," not executing tests

clojure-expectations / expectations-mode

Emacs minor mode for expectations test framework

GNU General Public License v3.0

21 stars 12 forks source link

"C-c ," not executing tests #11

Open JvJ opened 8 years ago

JvJ commented 8 years ago

When attempting to execute tests on a namespace from expectations mode, I get the following error message:

expectations-eval: Symbol’s function definition is void: nrepl-send-string

Is there some prerequisite emacs configuration/package that is necessary to get this to work.

Nrepl is currently installed. Current emacs version: GNU Emacs 25.0.50.1 (x86_64-w64-mingw32) of 2015-09-06.

edipofederle commented 8 years ago

@JvJ I fork this repo and fix something, maybe works for you: https://github.com/edipofederle/expectations-mode

Xylon2 commented 6 months ago

I believe nrepl-send-string is a function from older versions of cider. See this bug: https://github.com/clojure-emacs/cider/issues/1887

So as far as I can tell this library doesn't work at-all right now. I'll see if I can figure out how to fix it.

Xylon2 commented 6 months ago

Having looked into this, I noted this is broken in many ways:

breaking changes have happened in both cider and emacs itself in the past 10 years. for instance emacs no longer has lexical-let and cider nrepl-send-string-sync
this plugin is specifically designed for "OG" expectations and would need some changes to work with expectations.clojure.test
as mentioned in another ticket the installation method in the README is dead, and potentially a security issue since we don't know who owns that domain

Xylon2 commented 6 months ago

I made merge request to at-least remove the broken installation method and make clear the condition of the project https://github.com/clojure-expectations/expectations-mode/pull/18

seancorfield commented 6 months ago

Perhaps it also needs to be made clear that this mode -- expectations-mode -- is for "classic" Expectations only and is not needed for the clojure.test-compatible version of Expectations (and should not be used for that)?