search

clojure-lsp / clojure-lsp-intellij

Intellij Plugin for Clojure & ClojureScript development via Language Server (LSP) made in Clojure
https://clojure-lsp.io
MIT License
76 stars 5 forks source link

Download and use clojure-lsp instead of built-in initialize #34

Closed ericdallo closed 4 months ago

ericdallo commented 4 months ago

Fixes #25 #26 and #29 This will be a major change as it changes the core of the plugin on how to communicate with the server

ericdallo commented 4 months ago

Download this zip: clojure-lsp-1.14.10.zip, on Intellij install the plugin from zip

ericdallo commented 4 months ago

v2: clojure-lsp-1.14.10.zip

ericdallo commented 4 months ago

v3: clojure-lsp-1.14.10.zip

ericdallo commented 4 months ago

v4: clojure-lsp-1.14.10.zip

abreumatheus commented 4 months ago

Got the following stack trace using v4 on latest version of Intellij Ultimate. Looks like a malformed download URL.

java.io.FileNotFoundException: https://github.com/clojure-lsp/clojure-lsp/releases/download/2024.03.01-11.37.51/null
    at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1996)
    at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1589)
    at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:224)
    at java.base/java.net.URL.openStream(URL.java:1161)
    at clojure.java.io$fn__11621.invokeStatic(io.clj:239)
    at clojure.java.io$fn__11621.invoke(io.clj:235)
    at clojure.java.io$fn__11569$G__11523__11576.invoke(io.clj:69)
    at clojure.java.io$fn__11629.invokeStatic(io.clj:256)
    at clojure.java.io$fn__11629.invoke(io.clj:254)
    at clojure.java.io$fn__11569$G__11523__11576.invoke(io.clj:69)
    at clojure.java.io$input_stream.invokeStatic(io.clj:136)
    at clojure.java.io$input_stream.doInvoke(io.clj:121)
    at clojure.lang.RestFn.invoke(RestFn.java:410)
    at com.github.clojure_lsp.intellij.server$download_server_BANG_.invokeStatic(server.clj:77)
    at com.github.clojure_lsp.intellij.server$download_server_BANG_.invoke(server.clj:67)
    at com.github.clojure_lsp.intellij.server$start_server_BANG_$fn__21204.invoke(server.clj:146)
    at com.github.clojure_lsp.intellij.tasks$run_background_task_BANG_$run21108_impl__21110.invoke(tasks.clj:16)
    at com.github.clojure_lsp.intellij.tasks.proxy_plus21107.run(Unknown Source)
    at com.intellij.openapi.progress.impl.CoreProgressManager.startTask(CoreProgressManager.java:434)
    at com.intellij.openapi.progress.impl.ProgressManagerImpl.startTask(ProgressManagerImpl.java:132)
    at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcessWithProgressAsynchronously$5(CoreProgressManager.java:484)
    at com.intellij.openapi.progress.impl.ProgressRunner.lambda$submit$4(ProgressRunner.java:248)
    at com.intellij.openapi.progress.ProgressManager.lambda$runProcess$0(ProgressManager.java:73)
    at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcess$1(CoreProgressManager.java:192)
    at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$executeProcessUnderProgress$12(CoreProgressManager.java:610)
    at com.intellij.openapi.progress.impl.CoreProgressManager.registerIndicatorAndRun(CoreProgressManager.java:685)
    at com.intellij.openapi.progress.impl.CoreProgressManager.computeUnderProgress(CoreProgressManager.java:641)
    at com.intellij.openapi.progress.impl.CoreProgressManager.executeProcessUnderProgress(CoreProgressManager.java:609)
    at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:78)
    at com.intellij.openapi.progress.impl.CoreProgressManager.runProcess(CoreProgressManager.java:179)
    at com.intellij.openapi.progress.ProgressManager.runProcess(ProgressManager.java:73)
    at com.intellij.openapi.progress.impl.ProgressRunner.lambda$submit$5(ProgressRunner.java:248)
    at com.intellij.openapi.progress.impl.ProgressRunner$ProgressRunnable.run(ProgressRunner.java:498)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
    at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:702)
    at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:699)
    at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
    at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1.run(Executors.java:699)
    at java.base/java.lang.Thread.run(Thread.java:840)
ericdallo commented 4 months ago

v5: clojure-lsp-1.14.10.zip

~@abreumatheus please, try this one, it fixes that problem~ ah not really, that fixes another problem

ericdallo commented 4 months ago

v6: clojure-lsp-1.14.10.zip

@abreumatheus could you try this one please?

ericdallo commented 4 months ago

v7: clojure-lsp-1.14.10.zip

ericdallo commented 4 months ago

Latest version (same on current master)clojure-lsp-2.0.0.zip

mefryar commented 4 months ago

Latest version (same on current master)clojure-lsp-2.0.0.zip

When I install Clojure LSP from this ZIP, I get the following error when initializing IntelliJ. I realize maybe I just need to wait until the update is available via the IntelliJ Plugin Marketplace. But wanted to flag in case it is helpful.

java.io.FileNotFoundException: https://github.com/clojure-lsp/clojure-lsp/releases/download/2024.03.01-11.37.51/null
    at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1996)
    at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1589)
    at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:224)
    at java.base/java.net.URL.openStream(URL.java:1161)
    at clojure.java.io$fn__11621.invokeStatic(io.clj:239)
    at clojure.java.io$fn__11621.invoke(io.clj:235)
    at clojure.java.io$fn__11569$G__11523__11576.invoke(io.clj:69)
    at clojure.java.io$fn__11629.invokeStatic(io.clj:256)
    at clojure.java.io$fn__11629.invoke(io.clj:254)
    at clojure.java.io$fn__11569$G__11523__11576.invoke(io.clj:69)
    at clojure.java.io$input_stream.invokeStatic(io.clj:136)
    at clojure.java.io$input_stream.doInvoke(io.clj:121)
    at clojure.lang.RestFn.invoke(RestFn.java:410)
    at com.github.clojure_lsp.intellij.server$download_server_BANG_.invokeStatic(server.clj:77)
    at com.github.clojure_lsp.intellij.server$download_server_BANG_.invoke(server.clj:67)
    at com.github.clojure_lsp.intellij.server$start_server_BANG_$fn__21205.invoke(server.clj:146)
    at com.github.clojure_lsp.intellij.tasks$run_background_task_BANG_$run21108_impl__21110.invoke(tasks.clj:16)
    at com.github.clojure_lsp.intellij.tasks.proxy_plus21107.run(Unknown Source)
    at com.intellij.openapi.progress.impl.CoreProgressManager.startTask(CoreProgressManager.java:434)
    at com.intellij.openapi.progress.impl.ProgressManagerImpl.startTask(ProgressManagerImpl.java:132)
    at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcessWithProgressAsynchronously$5(CoreProgressManager.java:484)
    at com.intellij.openapi.progress.impl.ProgressRunner.lambda$submit$4(ProgressRunner.java:248)
    at com.intellij.openapi.progress.ProgressManager.lambda$runProcess$0(ProgressManager.java:73)
    at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcess$1(CoreProgressManager.java:192)
    at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$executeProcessUnderProgress$12(CoreProgressManager.java:610)
    at com.intellij.openapi.progress.impl.CoreProgressManager.registerIndicatorAndRun(CoreProgressManager.java:685)
    at com.intellij.openapi.progress.impl.CoreProgressManager.computeUnderProgress(CoreProgressManager.java:641)
    at com.intellij.openapi.progress.impl.CoreProgressManager.executeProcessUnderProgress(CoreProgressManager.java:609)
    at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:78)
    at com.intellij.openapi.progress.impl.CoreProgressManager.runProcess(CoreProgressManager.java:179)
    at com.intellij.openapi.progress.ProgressManager.runProcess(ProgressManager.java:73)
    at com.intellij.openapi.progress.impl.ProgressRunner.lambda$submit$5(ProgressRunner.java:248)
    at com.intellij.openapi.progress.impl.ProgressRunner$ProgressRunnable.run(ProgressRunner.java:498)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
    at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:702)
    at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:699)
    at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
    at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1.run(Executors.java:699)
    at java.base/java.lang.Thread.run(Thread.java:840)

macOS 14.3.1 IntelliJ IDEA 2023.3.4 (Community Edition) clojure-lsp-intellij 2.0.0

ericdallo commented 3 months ago

Thanks, @abreumatheus @mefryar, Could you try this one: clojure-lsp-2.0.0.zip

If not working, could you get the result of:

clj
> (System/getProperty "os.name" "generic")

and 

(System/getProperty "os.arch")
ericdallo commented 3 months ago

Got the problem, it happens with macos non aarch64, this one should fix: clojure-lsp-2.0.0.zip

mefryar commented 3 months ago

It works! 🎉 Confirming that all of https://github.com/clojure-lsp/clojure-lsp-intellij/issues/25 https://github.com/clojure-lsp/clojure-lsp-intellij/issues/26 and https://github.com/clojure-lsp/clojure-lsp-intellij/issues/29 now seem to be fixed for me. 👏

abreumatheus commented 3 months ago

Confirming that all of https://github.com/clojure-lsp/clojure-lsp-intellij/issues/25 https://github.com/clojure-lsp/clojure-lsp-intellij/issues/26 and https://github.com/clojure-lsp/clojure-lsp-intellij/issues/29 has been fixed for me as well on 2.0.0. 🎉