search

clojure-lsp / clojure-lsp-intellij

Intellij Plugin for Clojure & ClojureScript development via Language Server (LSP) made in Clojure
https://clojure-lsp.io
MIT License
76 stars 5 forks source link

Use UI dialog of particular type when more than 2 options #40

Open velios opened 3 months ago

velios commented 3 months ago

First of all, thanks for the great plugin and the time you spent developing it. Sorry if some of my text is worded impolitely. I am not a native speaker and cannot formulate my thoughts as I would like.

When i enable Clojure LSP "choose" popup window changes to this type image If i switch off Clojure LSP and stay with Cursive only popup in same place looks like this

Screenshot 2024-03-17 at 22 39 28

But i don't think it's something Cursive special, looks like different types of embedded IDEA popup window.

And for recently added feature #31 it's third type of dialog in same in my taste situation

Screenshot 2024-03-17 at 22 40 20

The second type of dialogue is quite convenient to use because it has many options for customization to suit every taste. If it's not too difficult, you can turn it on as the default option in Clojure LSP.

ericdallo commented 3 months ago

I know about that difference and the problem is that we are kind of making magic since IntelliJ CE doesn't support LSP in a easy way, so for now this is the best popup I could make it work, but indeed the second popup is the ideal, if you find a way to improve this LMK, I can check it again in the future

velios commented 2 months ago

I think rich dialog is named com.intellij.ui.components.JBScrollPane

image

Link to instructions for enabling this tool

ericdallo commented 2 months ago

Thanks @velios, I use this tool but JBScrollPane is just a scroll panel, also the problem here is not building the UI, I managed to build a similar UI, but the problem is how to integrate with the goToDeclaration API