search

clojure-vim / acid.nvim

Asynchronous Clojure Interactive Development
161 stars 12 forks source link

`gd` kills `:AcidEval` #65

Open elzibubble opened 5 years ago

elzibubble commented 5 years ago

Probably same as #21. Acid should tell you those other plugins are required and preferably how to fix the issue, rather than falling on its sword. Also the homepage should tell you to install these things.

(defn serialize-kv
  [k v]
  (str (->camelCaseString k) ": " (selmer-serialize v)))

;; A map containing `:ser-as :params`
(defmethod selmer-serialize :params
  [value]
  (->> (dissoc value :ser-as)
       (map #(apply serialize-kv %))
       (str/join ", ")))

If I use gd on serialize-kv near the bottom, running :AcidEval 5 no longer returns a response. No :messages.

K also doesn't work, though at least it doesn't kill eval.

hkupty commented 5 years ago

Hi, thanks for the issue.

I'm sorry for this. I assume this was a nrepl failure.

I have to revisit some decisions on error handling on this side. Nonetheless, I believe you are right if any dependency is missing, which I believe is.

How have you started the nrepl? Acid provides a way for it, but its currently not optimal.

I believe this navigation requires refactor-nrepl if I remember correctly, so if you're starting a nrepl session and connecting to it, it might be the case.

Please bear in mind that acid is developed on a best effort basis and despite my attempts, it's not easy to grow the developing community.

I wish a lot of this was in a better shape, but it's through issues like this one that I can improve it.

I'll look into it, but in the meantime, if you spawn a nrepl session using :lua require("acid.nrepl").start{}, it should be enough.

Sorry for the trouble and thanks for submitting the issue, I'll take a look at it later today.

Best regards, Henry

elzibubble commented 5 years ago

No worries, thanks for working on this thing. I'm probably not going to be able to use it immediately because there are Reasons it's awkward for me to add those dependencies. The virtualtext is pretty nice though and gd, when it works. I'll check back when my local issue is resolved.

I launched a REPL (with nrepl) in a separate terminal window and Acid seemed to connect to it automatically. That part actually worked seamlessly.