search

clojure-vim / acid.nvim

Asynchronous Clojure Interactive Development
161 stars 12 forks source link

Support jumping to all Clojure's symbols #75

Closed r6eve closed 4 years ago

r6eve commented 4 years ago

This PR supports jumping to all Clojure's symbols.

In reference about Symbols,

Symbols begin with a non-numeric character and can contain alphanumeric characters and *, +, !, -, _, ', ?, <, > and = (other characters may be allowed eventually).

I think that other characters mean /, #, % and &. / has already been included in iskeyword in Neovim v0.4.3, so I added others to iskeyword.

hkupty commented 4 years ago

Hi, I'm sorry for leaving this hanging for so long. This year has been very unusual and I barely worked on acid because of multiple reasons. This unfortunately fell out of my radar. Thanks a lot for the contribution.

Can I ask for a small change? In order not to cause "invisible" changes to user config, can you revert back the value of iskeyword at the end of the function?

Best regards and once again sorry a lot for not looking at this before, Henry

r6eve commented 4 years ago

Thank you for your detailed review. I fixed it and squashed the commits.