search

clojure / clojurescript-site

website for ClojureScript
Eclipse Public License 1.0
107 stars 135 forks source link

Quick Start mentions stack trace which no longer appears #305

Open mfikes opened 5 years ago

mfikes commented 5 years ago

In Quick Start:

Let’s make a mistake. Try evaluating (ffirst [1]). You should get a source mapped stack trace ...

But with recent changes stack traces are no longer printed by default:

ClojureScript 1.10.516
cljs.user=> (ffirst [1])
Execution error (Error) at (<cljs repl>:1).
1 is not ISeqable
mfikes commented 5 years ago

Potential solution:

Change the language to read:

Let’s make a mistake. Try evaluating (ffirst [1]) followed by (pst).

The REPL experience at that point might look like

ClojureScript 1.10.516
cljs.user=> (ffirst [1])
Execution error (Error) at (<cljs repl>:1).
1 is not ISeqable

cljs.user=> (pst)
Error: 1 is not ISeqable
     cljs.core/seq (out/cljs/core.cljs:1226:20)
     cljs.core/first (out/cljs/core.cljs:1235:16)
     cljs$core$ffirst (out/cljs/core.cljs:1751:4)
swannodette commented 4 years ago

Sounds good to me, PR welcome!