search

clojure / clojurescript-site

website for ClojureScript
Eclipse Public License 1.0
107 stars 135 forks source link

Tools section #389

Closed dgb23 closed 3 years ago

dgb23 commented 3 years ago

In regards to this issue: https://github.com/clojure/clojurescript-site/issues/387

I added three pages in the tooling section. I think the added tools (vscode and shadow-cljs) warrant mention on the site.

Caveat: The individual pages are small. I specifically didn't use leinigen for ClojureScript for a long time.

To accommodate the changes I suggest to change the navigation like so under tools.ftl:


<a href="vscode" class="w-nav-link clj-section-nav-item-link">Visual Studio Code</a>

<div class="w-nav-link clj-section-nav-heading">Build Tools</div>
<a href="leinigen" class="w-nav-link clj-section-nav-item-link">Leinigen</a>
<a href="shadow-cljs" class="w-nav-link clj-section-nav-item-link">shadow-cljs</a>
dgb23 commented 3 years ago

Forgot to mention: I also changed the jblake link to http. Issue: https://github.com/clojure/clojurescript-site/issues/388

dgb23 commented 3 years ago

I managed to consistently misspell Leiningen in this PR, which is a bit of a faux pas to say the least...

I plan on cleaning this up if you find this change generally useful. Also if you have other considerations I'm happy hear.

swannodette commented 3 years ago

@dgb23 looks like a good start - did you submit your CA?

puredanger commented 3 years ago

He is listed as a contributor at https://clojure.org/dev/contributors

puredanger commented 3 years ago

I updated the nav and the list page and deployed

swannodette commented 3 years ago

@puredanger thanks!

dgb23 commented 3 years ago

In the same commit I added a vscode.adoc which was merged but not linked under "editors". I think calva for vscode deserves mention there, as it is one of the more popular and beginner friendly options for both Clojure and ClojureScript development.

puredanger commented 3 years ago

Sorry, I missed that, will add!