search

clojurewerkz / buffy

Buffy The ByteBuffer Slayer, Clojure library for working with binary data.
194 stars 13 forks source link

deftest enum-field-write-test defined twice, reducing test coverage #4

Closed jafingerhut closed 10 years ago

jafingerhut commented 10 years ago

In namespace clojurewerkz.buffy.core-test the test name enum-field-write-test is used for more than one deftest, causing the first one's tests never to be run. I would recommend changing the name of one of the deftest's so they have different names.

Found using the pre-release version of the Eastwood Clojure lint tool.

michaelklishin commented 10 years ago

@jafingerhut why not simply submit a pull request that renames the 2nd test?

ifesdjeen commented 10 years ago

:+1: thank @michaelklishin @jafingerhut

jafingerhut commented 10 years ago

Michael, thanks for fixing the issue. I created an issue rather than submitting a pull request because I am filing a lot of issues on multiple projects discovered during testing of the lint tool, and I do not know how to create a pull request except by several more steps than it takes to create an issue.

ifesdjeen commented 10 years ago

@jafingerhut Thanks for providing a fix once again. You can check out the information on how to create a pull request here: https://help.github.com/articles/creating-a-pull-request

On the other hand, you can simply click "edit" on the file, if you're certain about the fix and just save the edit results.