search

clojurewerkz / buffy

Buffy The ByteBuffer Slayer, Clojure library for working with binary data.
194 stars 13 forks source link

Change 2 tests that were not testing anything useful #6

Closed jafingerhut closed 10 years ago

jafingerhut commented 10 years ago

They were of the form (is (= expr1) expr2), which always passes, because (= expr1) is always true. Changed them to what was probably intended, which is (is (= expr1 expr2)).

The tests fail now, but I do not know enough about the function being tested to know whether it is behaving as desired and the test should be changed, or whether the test is correct and the function behavior should change.

Found using a pre-release version of the Eastwood Clojure lint tool.

ifesdjeen commented 10 years ago

Nice finding! I already like that lint tool :)

ifesdjeen commented 10 years ago

thanks!