search

clojurewerkz / cassaforte

Modern, high-level Clojure driver (client) for Cassandra build around CQL 3
http://clojurecassandra.info
123 stars 52 forks source link

Upgrade metrics reporter to Metrics 3 #99

Open michaelklishin opened 9 years ago

michaelklishin commented 9 years ago

We should investigate if upgrading it to Metrics 3 is feasible.

michaelklishin commented 9 years ago

@ifesdjeen you seem to be on a roll recently, want to tackle this one? ;)

ifesdjeen commented 9 years ago

@michaelklishin sure boss no problem. let me bring the query api to some borderline stable mergeable state and i'll do that one too :)

michaelklishin commented 9 years ago

We should have an issue for that, as I've completely forgotten you were working on that :)

jwhitlark commented 9 years ago

@michaelklishin: I was thinking about taking a swing at this. One question, though: Is there any reason this doesn't use metrics-clojure?

michaelklishin commented 9 years ago

@jwhitlark not sure. I think it's reasonable to use metrics-clojure and depend on it since Cassaforte is a Clojure library and it is based on Metrics 3 already.

jwhitlark commented 9 years ago

Ok, I'll take a look and see if I run into any problems.

ifesdjeen commented 9 years ago

I can actually recommend using Dropwizard Metrics without any wrapper library. Their api is quite clean and I've found it easier to do it this way, mostly because the documentation of all the existing wrappers isn't as good as original.

As far as I understand, driver is already providing all the "gathering" of data. We only need to read out the information for reporting.

michaelklishin commented 9 years ago

@jwhitlark and I maintain metrics-clojure. So we can figure out the API :)

ifesdjeen commented 9 years ago

I'm sure you can figure out API, but I'm also a user of the library, and bringing in an extra dependency for something that's very simply done in Java isn't something I've tried to strip down all the extra dependencies for :)

We've tried metrics-clojure in our setup, and it was difficult for us to use, so we switched to pure java implementation. It's also very easy to use.

jwhitlark commented 9 years ago

Ok, I'm glad to hear what you guys are thinking. Let me take a look and see what makes sense to me after I've read through the code.

jwhitlark commented 9 years ago

I don't think I'm going to get to this anytime soon. If someone else wants to take it on, feel free.

michaelklishin commented 9 years ago

@jwhitlark no worries, thanks for the update. @ifesdjeen do you want to look into it?