search

clojurewerkz / meltdown

Clojure interface to Reactor, an event-driven programming and stream processing toolkit for the JVM
210 stars 13 forks source link

Corrected typo in Basic concepts section #1

Closed maacl closed 11 years ago

maacl commented 11 years ago

If I am not mistake "r" should be "reactor" in:

(mr/notify r "key" {:my "payload"})
michaelklishin commented 11 years ago

It's a code example that does not define any locals. Yes, the argument is indeed a Reactor. Would it be better to make it more demonstrative with a let that defines the argument?

maacl commented 11 years ago

If it is meant not to be connected to the two previous sub-sections and the reactor and subscription (which seems odd as "key" is used as key in both in the subscription and the pushed event) defined there, that should certainly be clarified somehow.

On Sun, Sep 22, 2013 at 8:13 PM, Michael Klishin notifications@github.comwrote:

It's a code example that does not define any locals. Yes, the argument is indeed a Reactor. Would it be better to make it more demonstrative with a let that defines the argument?

— Reply to this email directly or view it on GitHubhttps://github.com/clojurewerkz/meltdown/pull/1#issuecomment-24887184 .

michaelklishin commented 11 years ago

Good point, it is fairly clearly assumes the sections above are read first. OK, let's merge this and see if anyone complains about this version.

michaelklishin commented 11 years ago

:+1: