search

clojurewerkz / ogre

Clojure library for querying Apache TinkerPop graphs
http://ogre.clojurewerkz.org/
128 stars 28 forks source link

support gremlin 3.3.3 #103

Closed shooit closed 6 years ago

shooit commented 6 years ago

When I bumped the gremlin version to 3.3.3 and ran the tests the compiler noted that four tests were missing. I added support for the new select methods that take Traversals as arguments which I discovered as a new feature when implementing the missing tests. I did not add any other additional features. lein test is successful on my machine with these changes.

spmallette commented 6 years ago

Nice PR - thanks @shooit - Would a release on TinkerPop 3.3.3 be helpful to you right now?

shooit commented 6 years ago

No problem, happy to help. I thought it was more critical for us to get 3.3.3 out to keep up with AWS Neptune service, but the underlying issue wasn't a Gremlin version issue. That being said, its better for us to stay up to date than not. Thanks!