search

clojurewerkz / spyglass

A Clojure Memcached client (also: Couchbase, Kestrel). Built on top of SpyMemcached, supports ASCII and binary protocols, strives to be 100% feature complete.
http://clojurememcached.info
67 stars 17 forks source link

Update memcached and couchbase client deps #13

Closed liwp closed 9 years ago

liwp commented 9 years ago

Update the spymemcached and couchbase client dependencies to the latest versions. Both projects seem to have changed their artifact / project names.

liwp commented 9 years ago

The tests don't fail for me locally. Are the tests flaky or is something actually wrong?

michaelklishin commented 9 years ago

@liwp have you tried authentication? It was badly broken in releases newer than what we depend on (for Memcached, Couchbase is likely fine).

liwp commented 9 years ago

@michaelklishin TBH I haven't tried anything apart from running the test suite yet. I'll cut a private release from the PR today, test our project against it, and report back.

The reason why I want to update the dependencies is that we're using Datomic with Cassandra as the storage backend, and the Cassandra uses a version of Netty that conflicts with the version of the Couchbase client in Spyglass. And I haven't been able to make it work with :exclusions. Funnily enough the new Couchbase client doesn't use Netty anymore :smile:

liwp commented 9 years ago

@michaelklishin I've tried running against memcache with authentication and it seems to work fine. Unfortunately the project I'm working on doesn't have a great deal of tests for our memcached integration, so I can't be 100% confident that everything is fine.

Actually, I would be happy if just the couchbase dependency was upgraded since that's the one causing the version conflict for me.

liwp commented 9 years ago

@michaelklishin What do you want to do with this PR?

michaelklishin commented 9 years ago

@liwp I'll take your word that it works with authentication and merge.