search

clojurewerkz / spyglass

A Clojure Memcached client (also: Couchbase, Kestrel). Built on top of SpyMemcached, supports ASCII and binary protocols, strives to be 100% feature complete.
http://clojurememcached.info
67 stars 17 forks source link

Warnings about replacing clojure.core functions #20

Closed atroche closed 6 years ago

atroche commented 8 years ago

Hey guys,

I see that you're excluding flush + replace from the import from clojure.core, so how come importing spyglass still generates the following?

WARNING: flush already refers to: #'clojure.core/flush in namespace: clojurewerkz.spyglass.client, being replaced by: #'clojurewerkz.spyglass.client/flush
WARNING: replace already refers to: #'clojure.core/replace in namespace: clojurewerkz.spyglass.client, being replaced by: #'clojurewerkz.spyglass.client/replace

Cheers!

michaelklishin commented 6 years ago

A PR that adds excludes to the namespace would be welcomed.

atroche commented 6 years ago

@michaelklishin but as far as I can see the excludes are already there in that namespace. I must be missing something!

michaelklishin commented 6 years ago

I cannot reproduce:

user=> (require 'clojurewerkz.spyglass.client)
Reflection warning, clojurewerkz/spyglass/client.clj:130:24 - call to method set on net.spy.memcached.MemcachedClient can't be resolved (argument types: java.lang.String, unknown, unknown, unknown).
Reflection warning, clojurewerkz/spyglass/client.clj:205:6 - call to method incr on net.spy.memcached.MemcachedClient can't be resolved (argument types: java.lang.String, unknown, unknown, unknown).
Reflection warning, clojurewerkz/spyglass/client.clj:214:6 - call to method decr on net.spy.memcached.MemcachedClient can't be resolved (argument types: java.lang.String, unknown, unknown, unknown).
Reflection warning, clojurewerkz/spyglass/client.clj:228:34 - call to method cas on net.spy.memcached.MemcachedClient can't be resolved (argument types: java.lang.String, unknown, unknown, unknown).
Reflection warning, clojurewerkz/spyglass/client.clj:237:24 - call to method asyncCAS on net.spy.memcached.MemcachedClient can't be resolved (argument types: java.lang.String, unknown, unknown, unknown).

The excludes look correct to me.