search

clokep / django-querysetsequence

Chain multiple (disparate) QuerySets in Django
https://django-querysetsequence.readthedocs.io/
ISC License
107 stars 25 forks source link

Support Django 1.11 & 2.0 #32

Closed michael-k closed 7 years ago

michael-k commented 7 years ago

Tests are still failing, because Django master is not supported. https://travis-ci.org/michael-k/django-querysetsequence/builds/267246035

clokep commented 7 years ago

This seems to completely drop support for Django 1.9 from testing, is that done on purpose?

michael-k commented 7 years ago

Yes, see commit bdd62bc. Django 1.9 reached its end of life over 4 months ago. https://www.djangoproject.com/weblog/2017/apr/04/security-releases/

clokep commented 7 years ago

OK, but does it not work or are you just removing it because it's EOL?

michael-k commented 7 years ago

It should work, I haven't looked into it.

Btw. I'm working on another commit to add Django 2.0 support.

michael-k commented 7 years ago

I've added two more commits. The tests are green: https://travis-ci.org/michael-k/django-querysetsequence/builds/267263088

michael-k commented 7 years ago

@clokep Can you merge this? The PR is not against master, but your branch update-tox.

clokep commented 7 years ago

I'll take a look at this in the next couple of days! I missed the notification saying you had pushed, sorry!

clokep commented 7 years ago

Looks great. Thanks! 👍 Going to merge this to my other PR and clean-up the README/changelog a bit. (And sorry for the delay!)