clokep / django-querysetsequence

Chain multiple (disparate) QuerySets in Django
https://django-querysetsequence.readthedocs.io/
ISC License
108 stars 25 forks source link

Support filter(*args) #76

Closed jpic closed 4 years ago

jpic commented 4 years ago

Hi Patrick,

Some user contributed query building code similar to what django.contrib.admin does for search_fields.

This broke QSS support for two reasons:

What do you think of this proposal ? We have a patch ready in DAL and I can still do any changes to fit the design decisions that you may want to make.

Thank you for your feedback

clokep commented 4 years ago

@jpic The changes for filter() make sense, but I'm not so sure about the distinct() changes. See #31 for why that is a bit trickier. Maybe we can split this into two PRs for discussion?

jpic commented 4 years ago

Removed distinct from this PR, making another one for distinct, thank you !

clokep commented 4 years ago

Looks great! Thanks!