Support filter(*args) - Githubissues

jpic commented 3 years ago

Hi Patrick,

Some user contributed query building code similar to what django.contrib.admin does for search_fields.

This broke QSS support for two reasons:

it combines Q objects with | and then calls qss.filter(built_filter)
because of that, there is also code to detect if one of the filter is on an M2M table in which case it knowns it needs to call distinct

What do you think of this proposal ? We have a patch ready in DAL and I can still do any changes to fit the design decisions that you may want to make.

Thank you for your feedback

clokep commented 3 years ago

@jpic The changes for filter() make sense, but I'm not so sure about the distinct() changes. See #31 for why that is a bit trickier. Maybe we can split this into two PRs for discussion?

jpic commented 3 years ago

Removed distinct from this PR, making another one for distinct, thank you !

clokep commented 3 years ago

Looks great! Thanks!

clokep / django-querysetsequence

Support filter(*args) #76