search

clone45 / voxglitch

Modules for VCV Rack
GNU General Public License v3.0
101 stars 16 forks source link

Cardinal specific changes #126

Closed falkTX closed 2 years ago

falkTX commented 2 years ago

Hi there. Here is a set of changes to make voxglitch play nice with Cardinal. (just a little opensource audio plugin based on Rack)

These changes are required due to Cardinal not making use of osdialog, as it blocks the host event loop which IMO is quite the nasty thing to do as a plugin. So Cardinal has specific APIs for async dialogs, not interfering with host state.

I tried to make the changes as non-intrusive as possible. Some files had issues with spaces vs tabs, I cleared them a bit around the changes I made, so they look nicely aligned now. There should be no functional changes for the regular Rack / non-Cardinal builds.

Thanks for the great plugins!

clone45 commented 2 years ago

Thanks a ton for your work! I should have this merged tonight! Sorry for my somewhat redundant code everywhere. I haven't had a chance to write proper object-oriented code for some things. I may take a small break and start cleaning things up.

falkTX commented 2 years ago

No worries, compared to other stuff I have seen your code is quite nice, clean and well maintained :sweat_smile:

Would you perhaps be interested on a dark mode as well? This is how I have the modules looking like at the moment. (the red tint on the alien is intentional, it fits well with cardinal's red color)

Screenshot_20220307_163642