search

clone45 / voxglitch

Modules for VCV Rack
GNU General Public License v3.0
98 stars 16 forks source link

Fix up and adjust for Cardinal 22.07 #152

Closed falkTX closed 2 years ago

falkTX commented 2 years ago

Quite a few things were broken, now all fixed up and also updated to upcoming Cardinal changes.

PS: the whitespace (space vs tabs) is all over the place in your code, randomly mixing tabs and spaces. Would be great to clean that up sometime.

falkTX commented 2 years ago

Are the structure's variables not in scope in the callback for async_dialog_filebrowser?

Those values are passed into a lambda function, so they need to have local storage. We cannot pass regular class variables into a lamba.

falkTX commented 2 years ago

btw, you might want to see it since your modules are there. Just started doing a web version of cardinal too, see https://cardinal.kx.studio/

clone45 commented 2 years ago

btw, you might want to see it since your modules are there. Just started doing a web version of cardinal too, see https://cardinal.kx.studio/

Wow, that's amazing! I wonder how my new front panels are going to do in that environment. I'll contact you in the next few months. The graphic designer should be back soon and I'll be working on the PNG based panels again soon!