Groovebox START and END are a bit glitchy

clone45 / voxglitch

Modules for VCV Rack

GNU General Public License v3.0

98 stars 16 forks source link

Groovebox START and END are a bit glitchy #196

Closed jimallman closed 1 year ago

jimallman commented 1 year ago

Testing this in the groovebox_design branch.

Sometimes an existing non-zero START value is not restored? Or perhaps it's changing as the sequence plays (click and hold the START knob to see this).
Changes to END value can nudge START (and vice versa). This appears to be a temporary display bug, since the intended value re-appears when actually trying to edit the nudged value.
Moving START past the END actually works and shows a different highlight color. (Is this the intended behavior? Does this mean the sound plays backward? Should this nudge the REVERSE setting?)

clone45 commented 1 year ago

Hi Jim! I'm not seeing the same bugs that you are. I created a video showing the experience that I'm seeing: https://youtu.be/LuzZE6Xb6tY

Maybe I'm misunderstanding. Could you let me know how to recreate those bugs?

jimallman commented 1 year ago

Your video shows sensible behavior, and it's possible there's a different glitch on my end. (Please try merging https://github.com/clone45/voxglitch/pull/197 to try the new color schemes and let me know what you see.)

For some reason, my latest local builds are acting weird. Soft push-buttons aren't showing radio-button behavior, but just lighting up one after another. And choosing START, END, RATCHET doesn't show their alternate LCD displays. Odd.

I'll take a closer look using lldb to see if there are bugs that aren't showing up in Rack's log file. Hmmmmm.

clone45 commented 1 year ago

I had to make adjustments to your code to rearrange the mapping of parameters to the correct buttons. That threw me off for a while!

jimallman commented 1 year ago

For some reason, my latest local builds are acting weird.

Found it! The latest odd/missing behavior happens if we haven't chosen an outlet device for the patch. Now the alternate LCD displays are showing up for START/END/RACTHET, so I'll check again for the glitches reported above.

jimallman commented 1 year ago

I had to make adjustments to your code to rearrange the mapping of parameters to the correct buttons.

Apologies, I thought we had already discussed the mismatched buttons. (I figured this was introduced when tried refactoring the button-placement code to use initial and offset positions.)

clone45 commented 1 year ago

Apologies, I thought we had already discussed the mismatched buttons. (I figured this was introduced when tried refactoring the button-placement code to use initial and offset positions.)

No big deal. I'm prone to forgetting things. :-)

jimallman commented 1 year ago

Now the alternate LCD displays are showing up for START/END/RACTHET, so I'll check again for the glitches reported above.

OK, choosing an audio device seems to have fixed all the glitches I saw above. I'm still a bit confused about what happens when START comes after END, but I'm guessing you have a plan for this.