clone45 / voxglitch

Modules for VCV Rack
GNU General Public License v3.0
98 stars 16 forks source link

Just FYI: Some warnings building mac arm with latest clang #218

Open baconpaul opened 1 year ago

baconpaul commented 1 year ago
src/GrooveBox/widgets/LCDTrackDisplay.hpp:123:13: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]
        if (!module->lcd_screen_mode == module->TRACK)
            ^                        ~~
src/GrooveBox/widgets/LCDTrackDisplay.hpp:123:13: note: add parentheses after the '!' to evaluate the comparison first
        if (!module->lcd_screen_mode == module->TRACK)
            ^
             (                                       )
src/GrooveBox/widgets/LCDTrackDisplay.hpp:123:13: note: add parentheses around left hand side expression to silence this warning
        if (!module->lcd_screen_mode == module->TRACK)
            ^
            (                       )
src/GrooveBox/widgets/LCDTrackDisplay.hpp:400:13: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]
        if (!module->lcd_screen_mode == module->TRACK)
            ^                        ~~
src/GrooveBox/widgets/LCDTrackDisplay.hpp:400:13: note: add parentheses after the '!' to evaluate the comparison first
        if (!module->lcd_screen_mode == module->TRACK)
            ^
             (                                       )
src/GrooveBox/widgets/LCDTrackDisplay.hpp:400:13: note: add parentheses around left hand side expression to silence this warning
        if (!module->lcd_screen_mode == module->TRACK)
            ^
            (                       )

I am pretty sure you mean module->lcd_screen_mode != module->TRACK but you might actually mean not-the-mode but since TRACK is 0 it has the same effect I think.

No biggie just saw it doing an ARM build and figured I would drop a note

clone45 commented 1 year ago

Ah, thanks! I'll dig into that soon!