search

clone45 / voxglitch

Modules for VCV Rack
GNU General Public License v3.0
101 stars 16 forks source link

No gate on first beat in Digital Sequencer #47

Closed Revheim closed 4 years ago

Revheim commented 4 years ago

On the first beat, and on a reset I don't get any gate signal coming out.

clone45 commented 4 years ago

Thanks for the bug report! I'll take a peek asap.

clone45 commented 4 years ago

Ok, I fixed this and merged it into the master branch. I'll try to get a new version which includes this bugfix published in the next few days.

Revheim commented 4 years ago

Awesome, I'll compile and test now.

Revheim commented 4 years ago

Still not getting the first one to fire :/ Any way I can send you a patch for demonstration?

clone45 commented 4 years ago

Of course! I was able to recreate your issue when testing yesterday. Please send over the patch and I'll definitely check it out.

Revheim commented 4 years ago

I stripped down the patch and turned down the tempo to make it more obvious, and I just added a txt extension so I could upload here. In the patch, the bass drum is the most obvious to catch, it's being triggered from sequence four. I have also added a gate-seq-64 with the same pattern, if you move the cable from digital sequencer 4, and instead take the output from gate-seq-64 the first beat is heard. notriggerfirstbeat.vcv.txt

clone45 commented 4 years ago

How strange! I swore that my fix worked, but now it's definitely not working. Ha ha ha. I'm just starting my day job but I'll revisit this tonight. Thank for sending over that patch!

clone45 commented 4 years ago

Wait... I spoke too soon. I hadn't pulled down the most recent version. Everything looks ok to me. I wasn't able to use your exact patch because I was missing some of the modules. But I did recreate the basics and recorded a video for you. https://youtu.be/SP-NTnCEQJA. Take a peek and let me know what you think. :-)

Revheim commented 4 years ago

I'm getting the first gate coming through from sequence number 1, but only from number 1..? In this patch I've hooked the bass drum to number 4, and it's missing it's first beat. I added another Digital Sequencer, and recreated the gate-pattern in 1 and 2 in that one, and it works only from number one. It seems it's only sequence 1 that outputs the first gate...

clone45 commented 4 years ago

Oh ... yeah. That makes sense. I goofed up on that one. I'll get it fixed asap, but that may be tonight. I'll keep you posted.

Revheim commented 4 years ago

Awesome, and thanks for the quick response, thats really great :)

clone45 commented 4 years ago

Ok! I'm hoping that this last round of edits will do the trick. I tested in a few different scenarios and it appears to be OK now. Can you give it a shot?

Revheim commented 4 years ago

Sorry for the late reply, been a busy day. I just recompiled now, and so far it seems to work just as expected! Brilliant stuff, really loving this sequencer. Thanks for fixing everything so quickly :)