search

clone45 / voxglitch

Modules for VCV Rack
GNU General Public License v3.0
102 stars 16 forks source link

Digital Sequencer quick keys [minor fixes] #88

Open firolightfog opened 3 years ago

firolightfog commented 3 years ago

Hi,

Hoping that there's a slight chance :) that you'll review the code in the near future I'd like to draw your attention to a few minor but very handy possible enhancements.

Currently:

It would make more sense to increase/decrease the value to the upper/lower value as set in the "Snap" settings. Could you please consider changing it accordingly? On the other hand up/down keys are generally used for navigation on the VCV screen. Could you please change the quick key for Shift-Up/Down? What about Ctrl-Shift-Up/Down to increase/decrease all the values in the relevant sequence?

Currently:

I'd like to propose the introduction of 'c' and 'Shift-c' for clearing the CV or gate sequencer. I use your great Digital Sequencer too often and I have to admit that I need to restart my tune programming countless times.

Cheers, Andras

clone45 commented 3 years ago

HI Andres,

I'll do what I can. I'm going to start with the easy request first: The ability use "c" to clear the sequence. By the way, the module now supports the context-menu "randomize" feature. You can also copy/paste between sequences. :-)

I'll look into your other request about increasing and decreasing the values. I like the idea a lot, but it might take some bigger changes to how the front-end display maps to the values. I'm going to try and spend a little time every week on this module!

clone45 commented 3 years ago

@S0210 I've implemented your request, but I had to change the key from "c" to "ESC". C is already being used by copy/pasted, and delete and backspace are used to delete modules in VCV Rack. Escape seems like the next best choice. I'll probably make a few more updates before releasing this feature, but I'll try to touch base once I've submitted it to the repo.

firolightfog commented 3 years ago

No rush Bret! I'm grateful even for revisiting your code and flattered by you considering some of my suggestions!

I always wanted to copy between sequences (with the underlying RANGE, SNAP, S&H settings!) but never managed to do it. Actually after a few failed attempt I started copying everything to the clipboard (Ctrl-C), pasting it to a text editor (Notepad), modifying what I need, and copying it back to the module (Ctrl-P).

Yes, increasing/decreasing comes with quite a few design decisions to be considered. (Like increase of value 0.)

I didn't think of the 'c' conflict. I agree, 'Esc' seems to be a good choice. Another alternative solution could have been implementing 'double-r'. (Pressing 'r' clears values, pressing 'r' again randomizes values.) Quick and efficient (unlike my sequence copying solution I shared above). :P

Best regards, Andras

firolightfog commented 3 years ago

Hi Bret, This version isn't released yet, is it? I think I see still the old version in the Library. Regards, Andras

clone45 commented 3 years ago

Hi Andras,

I don't think so, but this feature been submitted along with a bunch of other updates that I made. You can keep an eye on it here if you'd like: https://github.com/VCVRack/library/issues/626

I'm taking a little time each day to port my module over to Rack 2. Once things wind down, I hope to create a video showing off the new features. One thing to note: I added a short quick-key reference in the right-click context menu, but I think that I left out the "ESC" quick key, but it exists. :-)

firolightfog commented 3 years ago

Thank you, Bret! Good luck with the V2 adventure! :) Cheers, A.

clone45 commented 3 years ago

Hey Andras, it looks like the library contains the most recent build. Could you take a peek an see if the ESC is working for you?

firolightfog commented 3 years ago

Wow, the 'f' & 'g' trick works unexpectedly well! What a great addition! It's a true bless.

Yes, 'Esc' is okay, 'r' is outstanding, 'shift-r' is wonderful.

I tremendously enjoy the 'copy selected sequence' feature but isn't the 'ctrl-c' short key conflicting the general usage? In 2,717 other modules it's dedicated to copying all the values to clipboard. I'm not sure if it's okay this way, but I don't have a better suggestion so I'm just enjoying the new opportunity as long as I can. :)

Another potential issue with 'ctrl-c' is that OUTPUT RANGE, SNAP and S&H information is not copied.

Strange to find the 'quick key reference' in the context menu but it's very handy. That's where I start the search anyway. Good choice, very intuitive!

It is a great update, Breat! Thank you!

Regards, A.

firolightfog commented 3 years ago

Actually why not using 'shift-c' for copying 'selected sequence' feature? Similarly to 'shift-r' it's working anyway with both of the gate and the CV part of the sequence.

And then the 'ctrl-c' could be dedicated to preset copying as it's default in VCV Rack: image

Similarly to this logic I would like you to consider for the future

Best regards, Andras

clone45 commented 3 years ago

Hi Andras,

You make a really good point about the "Copy Preset" collision. I'll try and get that updated soon. I agree that shift-c and shift-v are better choices. :-)

firolightfog commented 3 years ago

What am I expected to do if I want to delete GATES of track 6 only? Selection sequence #6, having the pointer over the gates, and pressing Esc doesn't seem to work for me. Regards, A.

clone45 commented 3 years ago

@S0210 Hi Andras. I'll have to take a look at that once V2 is released and I can build against it. In the meantime, I would recommend that you click on an active gate and drag across the other gates. Using this "swiping" technique, you can quickly set all of the gates on or off, depending on if you started by clicking on an active or inactive gate.