search

clonemeagain / attachment_preview

osTicket Plugin: Allows inline view of attachments
GNU General Public License v2.0
48 stars 16 forks source link

fixed #21 sintax error, support any php 5+ or 7+ #24

Closed mckaygerhard closed 6 years ago

mckaygerhard commented 6 years ago

the pluguin works perfect with osticket 1.9 but osticket 1.9 works with php 5.3 so able to work with any version.

i'll explain, if log parsing hav more that one arg, so the debug will parse and try to extract the rest of the arguments.. so no problem if are manage as array..

that's the reason why the secon arg its init with null to able to use with two or more on one arg only

clonemeagain commented 6 years ago

I mentioned this in #21, simply removing the splat operator will introduce an error unless the args are accounted for.

mckaygerhard commented 6 years ago

let me made the modifications, but in the future if you wish , you can directly alter the pull commit too..

i answered about the "unsupported" misc.meaning word and tests in the issue comment.. great work