not working on osticket 1.11

[corent56]

Hi, Since the upgrade to osticket 1.11 (the file preview is all white).

Corentin

[clonemeagain]

Hmm, that's annoying. I'll have to upgrade and fix it!

[ramrajone]

It was working fine in 1.11 rc1, I had tested with PHP Ver. 7.0.33

https://forum.osticket.com/d/93565-attachment-inline-plugin-not-working Hope it gets updated soon Thank you while back there were some changes: https://github.com/clonemeagain/attachment_preview/pull/29/files/eb4ab2dd5c0f705dcee7f9f56c241830ac7ed1cc

[clonemeagain]

Hey chief, I'm super busy ATM, started a new job and there's a lot of work on. My last was really easy so I had plenty of spare time to make plugins. If you can test with error reporting enabled and send me the logs we might be able to diagnose and patch it sooner. I'm close, had to buy a new PC and it's taking time to rebuild my development environment, apparently windows 10 and docker just do not play nicely. I'll have some time coming up that should be free, so don't hold your breath or anything, but in the next few days I should be able to replicate the issue and start working on it.

[ramrajone]

I totally understand and very much appreciated your work

I will do test and send you logs

Thank you again for your support

On Wed, Feb 27, 2019, 4:51 PM Aaron notifications@github.com wrote:

Hey chief, I'm super busy ATM, started a new job and there's a lot of work on. My last was really easy so I had plenty of spare time to make plugins. If you can test with error reporting enabled and send me the logs we might be able to diagnose and patch it sooner. I'm close, had to buy a new PC and it's taking time to rebuild my development environment, apparently windows 10 and docker just do not play nicely. I'll have some time coming up that should be free, so don't hold your breath or anything, but in the next few days I should be able to replicate the issue and start working on it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/clonemeagain/attachment_preview/issues/32#issuecomment-468045068, or mute the thread https://github.com/notifications/unsubscribe-auth/AgxHnOYlX9wDyCgutsSit5hNCkPJzWswks5vRv3UgaJpZM4a9Fpz .

[ramrajone]

It does not generate any errors

This message I see from working PDF preview plugin on osTicket ver. 1.10.4: [Deprecation] HTML Imports is deprecated and will be removed in M73, around March 2019. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 for more details.

compare side by side:

let me know steps that I can do and give you more info Thanks

[clonemeagain]

Got a quickly hacked up solution, that works for FF & Chrome in 1.11:

Required setting for Firefox: https://support.mozilla.org/en-US/kb/applications-panel-set-how-firefox-handles-files Chrome has PDF display enabled by default.

[clonemeagain]

If you want to test, please use this version: https://github.com/clonemeagain/attachment_preview/archive/1.11.zip or checkout the 1.11 branch.

I'll test it some more, then merge into master.

[ramrajone]

Hi, I just tested, chrome/Firefox worked just fine without any changes IE/Edge .jpeg worked, but .PDF did not, which I did not expect to work nether, Thank you very much for a quick fix

Chrome worked fine Version 72.0.3626.119 (Official Build) (64-bit) Version 72.0.3626.121 (Official Build) (64-bit)

Firefox worked fine too, no changes needed: 65.0.1 (64-bit) 65.0.2 (64-bit)

IE 11 [image: image.png]

Microsoft Edge 42.17134.1.0 [image: image.png]

On Fri, Mar 1, 2019 at 10:35 PM Aaron notifications@github.com wrote:

If you want to test, please use this version: https://github.com/clonemeagain/attachment_preview/archive/1.11.zip or checkout the 1.11 branch.

I'll test it some more, then merge into master.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/clonemeagain/attachment_preview/issues/32#issuecomment-468879219, or mute the thread https://github.com/notifications/unsubscribe-auth/AgxHnNjAxL8QijUeMCGdMbyXRfUx-D28ks5vSfGWgaJpZM4a9Fpz .

[clonemeagain]

Oh, yeah. IE has never supported the technique, so much so there is an admin option to practically insult the user for not using a better browser.

On Tue, 5 Mar. 2019, 00:14 ramrajone, notifications@github.com wrote:

Hi, I just tested, chrome/Firefox worked just fine without any changes IE/Edge did not, which I did not expect to work nether, Thank you very much for a quick fix

Chrome worked fine Version 72.0.3626.119 (Official Build) (64-bit) Version 72.0.3626.121 (Official Build) (64-bit)

Firefox worked fine too, no changes needed: 65.0.1 (64-bit) 65.0.2 (64-bit)

IE 11 [image: image.png]

Microsoft Edge 42.17134.1.0 [image: image.png]

On Fri, Mar 1, 2019 at 10:35 PM Aaron notifications@github.com wrote:

If you want to test, please use this version: https://github.com/clonemeagain/attachment_preview/archive/1.11.zip or checkout the 1.11 branch.

I'll test it some more, then merge into master.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/clonemeagain/attachment_preview/issues/32#issuecomment-468879219 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AgxHnNjAxL8QijUeMCGdMbyXRfUx-D28ks5vSfGWgaJpZM4a9Fpz

.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/clonemeagain/attachment_preview/issues/32#issuecomment-469248568, or mute the thread https://github.com/notifications/unsubscribe-auth/AE15jz7MAULr3UkOyWAAMBINNUFcctgLks5vTRwkgaJpZM4a9Fpz .

[corent56]

Thank you for the quick fix, it's working fine on chrome!