search

clonemeagain / attachment_preview

osTicket Plugin: Allows inline view of attachments
GNU General Public License v2.0
47 stars 16 forks source link

Fixes php8, ok for v1.16 but v1.17 still has problems #56

Closed perryk closed 1 year ago

perryk commented 2 years ago

These changes look to get the plugin working with php8 and likely are good for v1.16 of OsTicket.

However v1.17 looks to have significant changes to how plugins work and there is currently an issue.

This plugin can read it's settings during the bootstrap function, however it is unable to read those settings in other functions. Something to do with it now being possible to have multiple instances of plugins and which instance/instantiation is being referenced maybe.

We have changed the setting for "Max Size" to 4096 instead of the default of 1024. With the current RC3 of v1.17 this setting isn't detected, so it only shows images which are up the default of 1024 despite the setting.

As a work around, it is possible to change the default of that setting from the config.php, so it isn't too bad.

perryk commented 1 year ago

I'm hopeful there will be answer found between a couple of PRs from official OsTicket github repo where they are blacklisting older plugins which only expect to have a single instance.

6290 and #6277

and, PR # 238 from the official Osticket-plugins github repo has some fixes they needed for an official plugin.