search

clong / DetectionLab

Automate the creation of a lab environment complete with security tooling and logging best practices
MIT License
4.6k stars 980 forks source link

Hard coded network size in fix network script #750

Closed JustasZab closed 2 years ago

JustasZab commented 2 years ago

https://github.com/clong/DetectionLab/blob/719f0f846f6c75c3da05ada267af554061032b5f/Vagrant/scripts/fix-second-network.ps1#L14

It might make sense to centralise subnet size and push as a param to the script instead of hard coding.

Context for this is that I am deploying this infra into a /20 subnet and had to make some changes.

clong commented 2 years ago

Hi @JustasZab - for simplicity reasons, I probably won't add this functionality myself, but I'm happy to review any PRs. Also see: https://github.com/clong/DetectionLab/issues/602