search

clonn / slack-node-sdk

slack.com, slack, node sdk
MIT License
167 stars 32 forks source link

Crash in Slack.api when the response contains invalid JSON #20

Closed avuori closed 9 years ago

avuori commented 9 years ago

Probably desired instead of crashing: should call the callback with an error.

Relevant stack: SyntaxError: Unexpected token < at Object.parse (native) at Request. (/.../node_modules/slack-node/lib/lib/slack.seed.js:110:28)

(happens with version 0.1.3)

kevinburkeshyp commented 9 years ago

Fixed in https://github.com/clonn/slack-node-sdk/pull/21