search

clonn / slack-node-sdk

slack.com, slack, node sdk
MIT License
167 stars 32 forks source link

Additional payload options #22

Open farski opened 9 years ago

farski commented 9 years ago

There are some additional parameters that can be sent along with the payload (link_names, mrkdwn, etc), that currently get stripped out because the payload is being built explicitly. Would it be possible to make it so those options could get passed along?

kevinburkeshyp commented 9 years ago

hey! I believe you can do this... doesn't https://github.com/clonn/slack-node-sdk/blob/master/src/lib/slack.seed.coffee#L77 set any options you pass through on the request?

farski commented 9 years ago

@kevinburkeshyp I think maybe that works with the API but not webhooks, because only certain keys are being added to the payload https://github.com/clonn/slack-node-sdk/blob/master/src/lib/slack.seed.coffee#L36

strix commented 8 years ago

I agree with @farski. In my case, I want to override the unfurl_links option.

simonrand commented 7 years ago

+1 from me also, for now I've forked and added these options (https://github.com/clonn/slack-node-sdk/compare/master...simonrand:allow_unfurl_options) but would be nice to have this upstream..

(Not sure my changes are worth a PR? A little unclear how to add tests for these options..)