clonos / control-pane

ClonOS WEB control panel (CBSD WEB UI)
https://clonos.tekroutine.com
139 stars 35 forks source link

Possible bug #35

Open bozhinov opened 3 years ago

bozhinov commented 3 years ago

https://github.com/clonos/control-pane/blob/aef78b712561759469ab09d713cff967b6db212d/php/clonos.php#L2062

$add_cmd=($in_helper)?' default_jailname='.$this->url_hash:''; $add_cmd1=' default_jailname='.$type; $res=$this->cbsd_cmd("freejname".$add_cmd.$add_cmd1);

after refactoring this translates to: if ($in_helper) { $res = CBSD::run('freejname default_jailname=%s default_jailname=%s', array($this->url_hash, $type)); } else { $res = CBSD::run('freejname default_jailname=%s', array($type)); }

The double default_jailname looks weird it this correct ?

olevole commented 3 years ago

@moveee cbsd assumes one argument for default_jname. Can you check and remove the dubbing?