search

cloocher / xmlhasher

Fast XML to Ruby Hash converter
MIT License
40 stars 21 forks source link

Bump ox version, remove ruby-version #8

Closed zazaian closed 6 years ago

zazaian commented 7 years ago

This PR bumps the ox version from 2.2.1 to to ~> 2.8.0. Ox '2.2.1' was failing to build on my Ubuntu 16.04.3 LTS machine which seems like a fairly vital platform to be able to build for. Ox 2.8.0 built with no problem and has a myriad of other fixes.

I also removed /.ruby-version as it seemed odd for a gem to lock its own ruby version, especially with a ruby version already being set in the gemspec.

Ran the tests with ruby 2.4.2 and there were no failures.

wallenstone commented 6 years ago

Bump. Also experiencing build issues with ox 2.2.1 using ruby 2.5.0.

zazaian commented 6 years ago

@cloocher can we get this merged in?

JonMidhir commented 6 years ago

:+1:

cloocher commented 6 years ago

updated ox to latest version