search

cloojure / pcapng

PCAPNG Python library
Apache License 2.0
5 stars 4 forks source link

Support Python 3.x #2

Open cmcqueen opened 3 years ago

cmcqueen commented 3 years ago

I was really surprised to discover this Python package is 2.x only.

cloojure commented 3 years ago

Hi - It was written for a specific customer in 2017 with a requirement for Python2.

I'm not actively using PCAPNG anymore, but it could be easily upgraded. Mostly the string functions, I think.

Alan

On Mon, Oct 4, 2021 at 11:53 PM Craig McQueen @.***> wrote:

I was really surprised to discover this Python package is 2.x only.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cloojure/pcapng/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWBOBYN64Q3ILX5PEYD2ODUFKOGFANCNFSM5FLASZIQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

cmcqueen commented 3 years ago

See pcapng3 · PyPI. Maybe you could pull Python 3.x support from that (though its repo is in GitLab, not GitHub).

cmcqueen commented 3 years ago

Now that the Python project has sunset Python 2 (January 2020), arguably Python packages can drop support for Python 2.x and move entirely to 3.x.

Would you accept a pull request that made this package 3.x-only?

cloojure commented 3 years ago

Sure. The unit tests are pretty complete, so if it passes those it should be good.

On Tue, Oct 5, 2021 at 3:53 PM Craig McQueen @.***> wrote:

Now that the Python project has sunset Python 2 (January 2020), arguably Python packages can drop support for Python 2.x and move entirely to 3.x.

Would you accept a pull request that made this package 3.x-only?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cloojure/pcapng/issues/2#issuecomment-934976475, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWBOB6UVATD55JLOKOQQBLUFN6WTANCNFSM5FLASZIQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.