closeio / ciso8601

Fast ISO8601 date time parser for Python written in C
MIT License
565 stars 45 forks source link

Fix PyPy 2 build #116

Closed movermeyer closed 3 years ago

movermeyer commented 3 years ago

What are you trying to accomplish?

Fix the build failure for PyPy 2

This wasn't noticed as part of v2.2.0, since that version of PyPy hadn't yet been released (it had been merged, but not released).

What approach did you choose and why?

The check for whether PyPy supported the cPython 3.7's Timezone API was insufficient. It was just checking the PyPy version number, which is something that both PyPy 2 and PyPy 3 share.

We also still need to check the Python version.

What should reviewers focus on?

🤷

The impact of these changes

Builds will once again work for PyPy 2.

Testing

...