search

closeio / ciso8601

Fast ISO8601 date time parser for Python written in C
MIT License
564 stars 45 forks source link

Release v2.3.0 #134

Closed movermeyer closed 1 year ago

movermeyer commented 1 year ago

What are you trying to accomplish?

New release to include the bug fixes from #113 and #116. It also includes the performance improvements of #130 It also includes the spec coverage improvements of #139 and #140

What approach did you choose and why?

Bumping the version number and update the CHANGELOG. The usual.

I chose v2.3.0, since it expands the behaviour/scope of ciso8601 (with ordinal-dates and week-dates)

As a fun aside, with #130, ciso8601 is now 3x faster at parsing timestamps with time zone information than it was before v2.0.0

movermeyer commented 1 year ago

now require external actions to be verified on the github marketplace.

@AlecRosenbaum

By following these docs it seems that you can allowlist specific GitHub actions to be run. The workflow makes use of pypa/cibuildwheel and (eventually, commented out right now) pypa/gh-action-pypi-publish, which I feel are worth allow-listing, given their utility and that they are developed by PyPA (the same people who develop pip).

AlecRosenbaum commented 1 year ago

I wasn't able to get approval for allow-listing them, however I've forked them both into the closeio org (which means we can use them with closeio/cibuildwheel instead). I (accidentally) didn't copy the full repo history for pypa/gh-action-pypi-publish, so the tags aren't there. But it can be pinned by commit instead.

movermeyer commented 1 year ago

@AlecRosenbaum I manually ran the GitHub Action against this PR, and it produced both the wheels and the source distribution: https://github.com/closeio/ciso8601/actions/runs/3752178439#artifacts (artifact.zip contains all of them)

From here, I'd suggest chatting with @thomasst about manually uploading these artifacts as part of a release on PyPI. Note: You can use the Test PyPI (test.pypi.org) to make sure you understand the process and things are working before doing the real release.

Alternatively, we can look into completing the automation in the workflow, but that's a non-trivial amount of work for right now, and I'd rather see a release finally done (after 14 months) than delay any longer.

AlecRosenbaum commented 1 year ago

Done, v2.3.0 is now uploaded to PyPI. I've done some basic testing (and did so on test pypi too before uploading to actual pypi). From what I can tell it's working correctly when I do a pip install of ==2.3.0.

Thank you @movermeyer!

movermeyer commented 1 year ago

Thank you @AlecRosenbaum! It's great to finally have a release after so long and so many fixes and improvements! ❤️