closeio / closeio-api

Python API Client for Close
http://developer.close.com/
MIT License
65 stars 47 forks source link

Add custom User Agent to every request, and expose the version in a readable way #104

Closed eengoron closed 4 years ago

eengoron commented 4 years ago

Closes #80

This PR:

I used the same structure as the Cleancat repo to do this.

eengoron commented 4 years ago

Tagging @tsx for review as well because of his work on Cleancat and ReleaseRabbit

jkemp101 commented 4 years ago

I just did a little search about User Agent formats but we should confirm what format we want. Not sure if there is an RFC but I looked at this. That makes me think it should be something like this: Close/1.2 python (python-requests/2.21.0)

Edit: Or should it be Close/1.2 () python (python-requests/2.21.0)

eengoron commented 4 years ago

After talking with @jkemp101 -- I settled on Close/X python (python-requests/Y)